Merged
Conversation
Agent-Logs-Url: https://github.com/imponeer/properties/sessions/991c82f3-83c8-4b03-8e8b-5c8405750166 Co-authored-by: MekDrop <342641+MekDrop@users.noreply.github.com>
Claude
AI
changed the title
MekDrop
requested changes
Apr 2, 2026
- Changed CensorStringInterface to use __invoke magic method for cleaner API - Updated DefaultCensorString implementation to use __invoke - Removed CensorString facade as it was just a one-liner wrapper - Updated StringType to use ServiceLocator directly with invokable interface - Updated tests to work with new __invoke approach Agent-Logs-Url: https://github.com/imponeer/properties/sessions/94424d24-3031-44a8-bd50-1cef7e973185 Co-authored-by: MekDrop <342641+MekDrop@users.noreply.github.com>
Member
|
@claude[agent] resolve conflicts |
Co-authored-by: MekDrop <342641+MekDrop@users.noreply.github.com>
Contributor
Author
Conflicts resolved in commit ad99eb4. The main branch had refactored ServiceLocator to use lazy initialization instead of a const array, so I adopted that pattern while preserving the CensorStringInterface registration. |
Claude
AI
changed the title
Member
|
@claude[agent] make sure tests passes, phpcs and phpstan too!!!! |
Agent-Logs-Url: https://github.com/imponeer/properties/sessions/bb1970fc-133b-4153-90aa-276c3e381135 Co-authored-by: MekDrop <342641+MekDrop@users.noreply.github.com>
MekDrop
approved these changes
Apr 2, 2026
Copilot stopped work on behalf of
MekDrop due to an error
April 2, 2026 10:55
Merged
Claude AI
added a commit
that referenced
this pull request
Apr 2, 2026
Following the same pattern as CensorStringInterface (PR #85), replace the icms_core_Textsanitizer stub with a proper interface-based solution: - Added TextSanitizerInterface for text sanitization functionality - Added DefaultTextSanitizer as default implementation (pass-through) - Updated ServiceLocator to register TextSanitizerInterface - Modified StringType to use TextSanitizerInterface via ServiceLocator - Removed icms_core_Textsanitizer class from legacy-stubs.php - Kept phpstan-stubs.php for static analysis compatibility Users can now configure their own text sanitizer by registering a custom implementation with ServiceLocator, allowing integration with ImpressCMS or other sanitization libraries. Agent-Logs-Url: https://github.com/imponeer/properties/sessions/48caf56e-c644-4502-bd10-c59d175bbc3b Co-authored-by: MekDrop <342641+MekDrop@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.