Merged
Conversation
Following the same pattern as CensorStringInterface (PR #85), replace the icms_core_Textsanitizer stub with a proper interface-based solution: - Added TextSanitizerInterface for text sanitization functionality - Added DefaultTextSanitizer as default implementation (pass-through) - Updated ServiceLocator to register TextSanitizerInterface - Modified StringType to use TextSanitizerInterface via ServiceLocator - Removed icms_core_Textsanitizer class from legacy-stubs.php - Kept phpstan-stubs.php for static analysis compatibility Users can now configure their own text sanitizer by registering a custom implementation with ServiceLocator, allowing integration with ImpressCMS or other sanitization libraries. Agent-Logs-Url: https://github.com/imponeer/properties/sessions/48caf56e-c644-4502-bd10-c59d175bbc3b Co-authored-by: MekDrop <342641+MekDrop@users.noreply.github.com>
Claude
AI
changed the title
MekDrop
requested changes
Apr 2, 2026
…ubs.php - Renamed TextSanitizerInterface → TextDisplayFilterInterface (more descriptive) - Changed to __invoke pattern (consistent with CensorStringInterface) - Implemented proper default logic: HTML escaping and nl2br when html=0 - Deleted legacy-stubs.php completely (no longer needed) - Updated composer.json to remove legacy-stubs.php from autoload files - Updated phpcs.xml to remove legacy-stubs.php exclusion - Updated all references in StringType and ServiceLocator The interface now follows the same pattern as CensorStringInterface and provides a basic but functional default implementation. Agent-Logs-Url: https://github.com/imponeer/properties/sessions/a8e20bac-fdb2-48bc-bc77-25454b6c703a Co-authored-by: MekDrop <342641+MekDrop@users.noreply.github.com>
MekDrop
requested changes
Apr 2, 2026
Allow users to extend the class for partial functionality. Updated docblock to clarify that the class can be extended. Agent-Logs-Url: https://github.com/imponeer/properties/sessions/b3047197-9b8c-4c15-b65c-bc93633d2b43 Co-authored-by: MekDrop <342641+MekDrop@users.noreply.github.com>
Claude
AI
changed the title
MekDrop
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.