chore: upgrade dependencies - #511
Conversation
- klauspost/compress v1.19.0 -> v1.19.1 (patch) - quic-go/quic-go v0.60.0 -> v0.61.0 (minor, verified compatible with internal/http3/) - jordanlewis/gcassert -> v0.0.0-20260313214104-ad3fae17affe (indirect) - rogpeppe/go-internal v1.10.0 -> v1.15.0 (indirect) - yuin/goldmark v1.4.13 -> v1.8.4 (indirect) - golang.org/x/mod v0.37.0 -> v0.38.0 (indirect) - golang.org/x/tools v0.47.0 -> v0.48.0 (indirect) All tests pass (go build, go vet, go test ./...), including internal/http2 and internal/http3 packages. No source code changes.
imroc
left a comment
imroc
left a comment
There was a problem hiding this comment.
Review pass — dependency upgrade only (go.mod/go.sum).
Verified:
quic-gov0.60.0 → v0.61.0 (minor): nointernal/http3/source changes needed. CI passes on both Go 1.25.x and 1.26.x, confirming the vendored HTTP/3 code is compatible with the new quic-go API.klauspost/compressv1.19.0 → v1.19.1 (patch).- Indirect deps (gcassert, go-internal, goldmark, x/mod, x/tools) — no source impact.
- No source code files modified.
Note for future sync: The x/net version remains at v0.57.0. When the next vendored internal/http2/ upstream sync happens, the baseline commit should be compared against the golang.org/x/net@v0.57.0 tag to ensure no missed changes.
No blockers. Since this is the repo owner's PR, leaving a comment review instead of self-approving.
imroc
left a comment
imroc
left a comment
There was a problem hiding this comment.
Automated review (PR Review Loop):
This PR has been superseded by #513, which contains all of the upgrades here (quic-go v0.61.0, compress v1.19.1) plus icholy/digest v1.2.0. Recommend closing this in favor of #513 to avoid duplicate merges.
No blockers on this PR itself — CI passes, no source changes, quic-go v0.61.0 compatibility previously verified.
|
Superseded by #514 which includes the same upgrades plus additional verification. |
1 participant
Dependency Upgrades
klauspost/compressquic-go/quic-gojordanlewis/gcassertrogpeppe/go-internalyuin/goldmarkgolang.org/x/modgolang.org/x/toolsVerification
go build ./...— passgo vet ./...— passgo test ./...— all packages pass (includinginternal/http2andinternal/http3)go mod tidy— no residual changesNotes
internal/http3/was not touched — onlygo.mod/go.sumchanged. Build and tests confirm the modifiedinternal/http3/code is compatible with quic-go v0.61.0.utls(v1.8.2),x/net(v0.57.0),x/crypto(v0.54.0),x/text(v0.40.0) — already up to date, no change.go.modandgo.sum.