fix(roundhouse): move done marker ahead of telemetron; log sidecar bootstrap#48
Open
royosherove wants to merge 2 commits intomainfrom
Open
fix(roundhouse): move done marker ahead of telemetron; log sidecar bootstrap#48royosherove wants to merge 2 commits intomainfrom
royosherove wants to merge 2 commits intomainfrom
Conversation
…otstrap P2a: _telemetron_sidecar runs synchronously and can block for up to ~60s (install) + 30s (detect) + AWS probe timeouts before the pack's done marker is written. That delays completion signaling for callers that wait on the marker, contradicting the section's 'never blocks main install' contract. Call write_done_marker *before* running the sidecar, wrapped in '|| true' so optional sidecar work can't gate pack success. P2b: the telemetron first-install 'curl ... | bash' ran without stdout/stderr redirection, so on fresh hosts its output leaked to the user terminal. Redirect to $log so the silent-only contract holds for first installs too. Addresses Codex P2 x2 on PR #47 (post-merge follow-up).
Follow-up to 3b71714 \u2014 the previous commit covered P2a (done marker) but the P2b edit for redirecting the first-install bootstrap output didn't land. Append '>>$log 2>&1' to the 'timeout 60 bash -c ...' wrapper so the section's silent-only contract also holds on fresh hosts where telemetron is missing. Addresses the second half of Codex review on PR #47.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Codex review on #47 (post-merge follow-up): #47 (review)
_telemetron_sidecarran synchronously beforewrite_done_marker, so the pack could be delayed by up totimeout 60(install) +timeout 30(detect) + AWS probe waits before signaling completion. Movedwrite_done_marker "roundhouse"to run before the sidecar subshell, with|| trueso sidecar failures can't gate the pack.curl ... | bashhad no stdout/stderr redirection, so on fresh hosts its progress lines reached the user terminal, breaking this section's silent/log-only contract. Appended>>"$log" 2>&1to thetimeout 60 bash -c ...wrapper.