Skip to content

fix(roundhouse): move done marker ahead of telemetron; log sidecar bootstrap #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
royosherove wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(roundhouse): move done marker ahead of telemetron; log sidecar bootstrap #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b71714
fix(roundhouse): move done marker ahead of telemetron; log sidecar bo…
royosherove May 6, 2026
1c68e56
fix(roundhouse): redirect telemetron curl|bash bootstrap to $log
royosherove May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packs/roundhouse/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,14 +235,16 @@ _telemetron_sidecar() {
# Install telemetron binary if not already present.
# No env vars = install.sh only downloads the binary, skips setup.
# We use `telemetron detect` for configuration instead.
# Redirect to $log so first-install curl|bash output doesn't leak to the
# user terminal (this section's contract is silent, log-only).
if ! command -v telemetron >/dev/null 2>&1 \
&& [[ ! -x /var/lib/telemetron/bin/telemetron ]]; then
local connect_to=5
local max_to=55
timeout 60 bash -c "
set -euo pipefail
curl --connect-timeout $connect_to --max-time $max_to -fsSL '$install_url' | bash
" || {
" >>"$log" 2>&1 || {
printf '[telemetron] install failed (exit %d) — continuing\n' "$?" >>"$log"
return 0
}
Expand Down Expand Up @@ -275,11 +277,16 @@ _telemetron_sidecar() {
printf '[telemetron] detect completed successfully\n' >>"$log"
}

# ── Done ──────────────────────────────────────────────────────────────────────
# Mark install complete BEFORE running the telemetron sidecar so callers that
# wait on the done marker aren't blocked by sidecar work (which has bounded
# but real timeouts: 60s install + 30s detect + AWS probe waits). The sidecar
# is optional — its success or failure must not gate pack completion.
write_done_marker "roundhouse"

(
set +e
_telemetron_sidecar
) || true

# ── Done ──────────────────────────────────────────────────────────────────────
write_done_marker "roundhouse"
printf "\n[PACK:roundhouse] INSTALLED — Telegram bot connected (systemd: roundhouse)\n"