fix(lambda): restore masked strings in WebUIUserCreationFunction - #84
Merged
Conversation
Two literal *** artifacts leaked into the Lambda ZipFile in PR #83: Line 1599: Password=*** → Password=password, Line 1643: password = ***) → password = generate_password() These were sanitized display masks (from a tool that redacts what looks like secrets when rendering diffs) that got baked into the on-disk file during a splice operation. The Lambda failed at import with Runtime.UserCodeSyntaxError: unmatched ')' so the WebUIUserCreationResource never completed. Impact: stack kirocrew-7-233-stack got stuck in CREATE_IN_PROGRESS because CFN kept re-invoking the broken Lambda. Stack was manually deleted; no data lost. Verification: - python3 ast.parse on extracted ZipFile: OK (111 lines) - aws cloudformation validate-template: OK (38 params) - bash -n install.sh: OK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Lambda ZipFile in the CFN template had two literal
***artifacts from a display-mask that got baked into the file during a splice:Password=***→Password=password,password = ***)→password = generate_password()Result: Lambda failed at import with
Runtime.UserCodeSyntaxError: unmatched ')'. Custom resourceWebUIUserCreationResourcenever completed. Stackkirocrew-7-233-stackgot stuck in CREATE_IN_PROGRESS.Fix verified:
python3 ast.parseon extracted ZipFile: OK (111 lines)aws cloudformation validate-template: OK (38 params)bash -n install.sh: OKBroken stack has been deleted.