fix(installer): STACK_NAME not ENV_NAME + guard post-deploy pipes - #85
Merged
Conversation
Two bugs caused exit code 254 after 'Stack created!' completed successfully: 1. **Wrong stack name**: Post-deploy Cognito output block used $ENV_NAME (e.g. 'kirocrew-8-549') instead of $STACK_NAME (e.g. 'kirocrew-8-549-stack'). aws cloudformation describe-stacks returned 254 (stack not found), pipefail propagated, set -e killed the script before show_complete ran. 2. **Unguarded pipes with pipefail**: 'aws ... | jq ...' fails the whole pipeline if either side errors. Wrapped each fetch with '|| true' and uses jq default '// empty' / '// []' so partial output failures no longer abort the installer. Result: the credential display box now shows even if a specific output is missing, and show_complete (which prints the click-through token URL) runs to completion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs caused exit code 254 after 'Stack created!' printed successfully:
Wrong stack name: Post-deploy Cognito output block used
$ENV_NAME(e.g.kirocrew-8-549) but the actual stack name is${ENV_NAME}-stack(set at line 2560 as$STACK_NAME).aws cloudformation describe-stacksreturned 254 (stack not found), pipefail propagated, set -e killed the script beforeshow_completeran — including the click-through token URL.Unguarded pipes with pipefail:
aws ... | jq ...fails the whole pipeline if either side errors. Wrapped each fetch with|| trueand uses jq default// empty/// []so partial output failures no longer abort the installer.Symptom Roy hit:
Also: the KiroCrew click-through token URL in
show_completenever printed because we exited before reaching it.