chore(deps): bump golangci/golangci-lint-action from 7 to 9#2
Merged
royosherove merged 1 commit intomainfrom May 9, 2026
Merged
Conversation
d09beaf to
407c63d
Compare
407c63d to
cb493ce
Compare
f67600a to
6921e1d
Compare
Member
|
@dependabot rebase |
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 7 to 9. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v7...v9) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-version: '9' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
6921e1d to
e0444b3
Compare
royosherove
added a commit
that referenced
this pull request
May 3, 2026
…orm preconditions, idempotency, diagnostics (#10) * fix(setup): fail-fast on unresolvable session-dir / run-as under root (#1) * fix(setup): bump health timeout to 60s, add --health-timeout (#2) * feat(setup): unsupported-platform preconditions for Darwin + non-systemd (#3) * fix(install): default HOME, drop blind set -u (#4) * fix(setup): skip restart when config unchanged (#5) * feat(setup): surface last HTTP response in health-check error (#6) * feat(setup): step-by-step progress output + SilenceUsage (#7) * docs: TELEMETRON_TOKEN_SECRET env in install.sh --help and setup summary (#8) * docs: bless install.sh auto-setup (update setup plan + CHANGELOG) (#9) * chore(lint): satisfy staticcheck error-string rules --------- Co-authored-by: Roy Osherove <575051+royosherove@users.noreply.github.com>
royosherove
added a commit
that referenced
this pull request
May 3, 2026
…ient-side install_id - Drop v1's standalone-infra approach after discovering lowkey installer already generates install_id/machine_id and posts to telemetry.loki.run - New route POST /v1/enroll as a new Lambda alongside existing install/ingest - Client sends install_id as OTel resource attr (Roy's call over Codex's #2); server strips it before AMP mirror to avoid durable metrics-plane labels - Defer renewal, revocation, admin CLI, anomaly scoring to v0.3.1 - Scope drops from ~29h to ~12.5h Codex review v2 pending.
royosherove
added a commit
that referenced
this pull request
May 3, 2026
Blocker #2 (HIGH): TELEMETRON_TOKEN_SECRET precedence was broken. Setting the env var suppressed the 'missing token' error but the secret was never resolved, so setup silently fell through to auto- enroll. Operators running with a managed-token flow would get an anonymous token instead, with no warning. Fix: loadTokenOrEnroll now hard-fails with ErrTokenSecretNotResolved when TELEMETRON_TOKEN_SECRET is set but no token has been staged and no --token-file is given. install.sh continues to be the canonical resolver (fetches from Secrets Manager and stages to /etc/telemetron/token before invoking setup). Direct 'telemetron setup' callers that set only TELEMETRON_TOKEN_SECRET now see a clear error instead of silent downgrade. Added cmd/telemetron/enrollment_test.go covering: - TELEMETRON_TOKEN_SECRET + no staged token -> ErrTokenSecretNotResolved - TELEMETRON_TOKEN_SECRET + staged token -> reads from file - shouldAttemptAutoEnroll respects all three precedence env vars - baseline auto-enroll happy path via httptest server Blocker #3: Plan required Firehose/Athena install_id promotion. The current loki-telemetry ingester writes to AMP remote_write only with no Firehose sink. Rather than build a warehouse path with no consumer, the plan doc is updated to mark Firehose promotion deferred to v0.3.2+ (when a warehouse sink is actually wired). The server-side install_id rebinding already happens, so the promotion is a trivial no-op layer to add later. Also fixed: - docs/privacy.md now lists deployment_id, tier, environment, pack_version as flush-time OTLP resource attributes (completeness) - CHANGELOG corrected: TELEMETRON_TOKEN_SECRET precedence claim now matches the implementation - DRY: internal/enroll/enroll.go now uses installid.Validate instead of maintaining its own UUIDv4 regex All tests passing, go vet clean.
de8130d to
3b187d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps golangci/golangci-lint-action from 7 to 9.
Release notes
Sourced from golangci/golangci-lint-action's releases.
Commits
1e7e51ebuild(deps): bump yaml from 2.8.1 to 2.8.2 in the dependencies group (#1324)5256ff0build(deps-dev): bump the dev-dependencies group with 3 updates (#1323)13fed6fchore: update workflows7afe8ffchore: update workflows5a92899chore: move samples into fixtures (#1321)aa6fad0feat: add version-file option (#1320)a6071aabuild(deps): bump actions/checkout from 5 to 6 (#1318)6e36c84build(deps-dev): bump the dev-dependencies group with 2 updates (#1317)e7fa5acfeat: automatic module directories (#1315)f3ae99fdocs: organize options (#1314)