rename slot, relationship - #59
Merged
Merged
Conversation
Contributor
|
Change name to 'relation' to align with pedigree spec (and avoids any confusion with LinkML term relationship_types).
Collaborator
|
I changed the naming a little- if this is acceptable we can merge it in. This is a breaking change- not sure if there's a special way to flag that. |
RobertJCarroll
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to load the entire SQL Alchemy model to extract the DDL for schema generation, the slot, relationship, is causing a namespace collision inside the FamilyRelationship model with the SQLA's property with the same name, overriding the ORM functionality with a class member. This results in errors when you try to actually follow the relationships associated with that class.
This simply renames the slot, relationship, to relationship_type. The new name can be (almost) anything other than 'relationship'.
Closes #58