feat: migrate terminal output to herald typography system#256
Merged
Conversation
Introduce herald-backed printer with themed typography, replacing raw ANSI escape codes in the console package. Add theme.go with SleyTheme and ResolveTheme for named theme support. Initialize typography via printer.Init(theme) in the CLI Before hook. Co-Authored-By: claude <noreply@anthropic.com>
Use herald Compose, H2, H4, UL, KV, KVGroup, Table, Code, CodeBlock, Tags, and Section across discover, doctor, init, changelog, extension, hooks, workspace formatter, and extensionmgr output. Replace manual string formatting with structured typography elements for consistent visual hierarchy. Co-Authored-By: claude <noreply@anthropic.com>
Replace blanket PrintSuccess/PrintInfo with PrintFaint and Info() highlights on key values (versions, paths, names) for a cleaner visual balance. Errors and warnings remain colored. Quiet-mode summaries are unchanged. Co-Authored-By: claude <noreply@anthropic.com>
Remove local printer.Section and printer.BR implementations in favor of herald v0.13.0 Typography.Section(). Update all call sites to use ty.Section() directly. Co-Authored-By: claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate all terminal output from raw lipgloss/ANSI styling to the herald typography library for consistent, themed output across all commands.
Key changes:
printer.Init(theme)initializes a package-level*herald.Typographywith named theme support (sley, dracula, catppuccin, base16, charm). CustomSleyTheme()with teal brand colors.internal/console/- Raw ANSI escape codes fully replaced by herald-backed printer functions.Compose,H2,H4,UL,KV,KVGroup,Table,Code,CodeBlock,Tags,Sectionused across discover, doctor, init, changelog, extension, hooks, workspace formatter, and extensionmgr.PrintSuccess/PrintInfowithPrintFaint+Info()highlights on key values (versions, paths, names) for cleaner visual balance. Errors and warnings stay colored.Section/BRimplementations, use upstreamTypography.Section().--module/--modules/--patternflags are explicitly set.Commits:
refactor: replace console package with herald typography systemrefactor: migrate command output to herald typographystyle: use faint text with selective color highlights across commandschore(deps): update herald to v0.13.0 and use Section/BR from upstreamRelated Issue
Notes for Reviewers