release: publish the MIT set before the GPL one - #159
Closed
pcarrier wants to merge 1 commit into
Closed
Conversation
publish-npm-bin-packages walks .publish-order under set -e, and sorting the platform packages together put the GPL ones ahead of the @blit-sh/bin launcher: any GPL publish failure would abort the run before @blit-sh/bin went out, which is exactly the breakage this is fixing. Emit each flavor as a block, MIT first.
|
Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #157: the fix for the review comment about
.publish-orderwas pushed to the branch after the merge commit was cut, so it never landed onmain.publish-npm-bin-packageswalks.publish-orderunderset -e. Sorting all platform packages into one block puts@blit-sh/bin-gpl-*ahead of the@blit-sh/binlauncher, so a failure publishing any GPL package aborts the run before the MIT launcher — the thing everyone installs — goes out. That's the same class of breakage #157 was fixing.Emit one block per flavor, MIT first:
Verified against fixture tarballs for both the full set (above) and a MIT-only artifact dir (no GPL block,
@blit-sh/binlast).Tag
@indentto continue the conversation here.