Crosslink 23#29
Merged
Merged
Conversation
JanisSaldabols
force-pushed
the
CROSSLINK-23
branch
from
February 6, 2025 08:49
696c849 to
79c6aa4
Compare
Contributor
|
@JanisSaldabols please resolve conflicts and remove the hardcoded 172... before merging this (see pull/34) |
adamdickmeiss
left a comment
Contributor
There was a problem hiding this comment.
I don't know enough abt the functionality to approve.
Something is up with the way we use Docker (compose).
JanisSaldabols
force-pushed
the
CROSSLINK-23
branch
from
February 6, 2025 16:29
6fb6f8b to
a41c83f
Compare
adamdickmeiss
self-requested a review
February 6, 2025 17:54
adamdickmeiss
approved these changes
Feb 6, 2025
adamdickmeiss
left a comment
Contributor
There was a problem hiding this comment.
OK. The supplierlocater_test.go test issue in another PR.
jakub-id
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.