Skip to content

Crosslink 23#29

Merged
JanisSaldabols merged 18 commits into
mainfrom
CROSSLINK-23
Feb 7, 2025
Merged

Crosslink 23#29
JanisSaldabols merged 18 commits into
mainfrom
CROSSLINK-23

Conversation

@JanisSaldabols

Copy link
Copy Markdown
Collaborator

No description provided.

@jakub-id

jakub-id commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

@JanisSaldabols please resolve conflicts and remove the hardcoded 172... before merging this (see pull/34)

@adamdickmeiss adamdickmeiss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough abt the functionality to approve.

Something is up with the way we use Docker (compose).

Comment thread broker/adapter/directory.go
Comment thread broker/docker-compose-test.yml Outdated
Comment thread broker/app/app.go Outdated
@adamdickmeiss
adamdickmeiss self-requested a review February 6, 2025 17:54

@adamdickmeiss adamdickmeiss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. The supplierlocater_test.go test issue in another PR.

@JanisSaldabols
JanisSaldabols merged commit 0052983 into main Feb 7, 2025
@JanisSaldabols
JanisSaldabols deleted the CROSSLINK-23 branch February 18, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants