ILLDEV-493 Don't send email if no patron requests are found - #740
Merged
Conversation
JanisSaldabols
requested review from
adamdickmeiss and
jakub-id
as code owners
August 28, 2026 10:11
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents pull-slip emails when no patron requests match.
Changes:
- Returns a successful no-op result for empty batches.
- Updates tests to cover empty and non-empty results.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
broker/scheduler/service/email_sender.go |
Skips email generation for empty batches. |
broker/scheduler/service/email_sender_test.go |
Adjusts and adds email-sending tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jakub-id
requested changes
Aug 28, 2026
JanisSaldabols
force-pushed
the
ILLDEV-493
branch
from
August 31, 2026 06:01
182e9b5 to
7e0e5a6
Compare
Contributor
|
@JanisSaldabols for sure we should not include the pdf if there's no results. But could we make the sendig configurable with an action param? Eg |
jakub-id
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.