Transaction log ILLDEV-380 - #28
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a reusable event-log UI component and adds a new “Transaction log” section to patron request view, while refactoring the existing Event History section to use the shared log UI.
Changes:
- Added a shared
EventLogcomponent with filtering, match counts, and row/detail rendering. - Added a new
TransactionLogsection that lazily fetches ILL transaction summary + events for borrowing requests. - Refactored
EventHistoryto useEventLogand removed the bespoke Event History row/header/CSS implementation.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ui-rs/translations/ui-rs/en.json | Adds i18n strings for the new Transaction Log and EventLog filter UI; updates an Event History label. |
| ui-rs/src/routes/ViewRoute.test.js | Updates test comment to reflect the renamed/used details component. |
| ui-rs/src/components/ViewPatronRequest/sections/TransactionLog/TransactionLog.test.js | Adds coverage for lazy fetch, empty/no-transaction states, lending behavior, and record changes. |
| ui-rs/src/components/ViewPatronRequest/sections/TransactionLog/TransactionLog.js | Implements the Transaction Log accordion, lazy Okapi queries, and summary rendering above an event list. |
| ui-rs/src/components/ViewPatronRequest/sections/TransactionLog/index.js | Exposes the TransactionLog section via an index export. |
| ui-rs/src/components/ViewPatronRequest/sections/index.js | Registers TransactionLog in the sections list for the ViewPatronRequest UI. |
| ui-rs/src/components/ViewPatronRequest/sections/EventHistory/EventHistory.js | Refactors EventHistory to render via the shared EventLog component. |
| ui-rs/src/components/ViewPatronRequest/sections/EventHistory/EventHistoryRow.js | Removes the prior per-event accordion row implementation (replaced by EventLog). |
| ui-rs/src/components/ViewPatronRequest/sections/EventHistory/EventHistoryHeader.js | Removes the custom accordion header (no longer needed with EventLog layout). |
| ui-rs/src/components/ViewPatronRequest/sections/EventHistory/EventHistory.css | Removes EventHistory-specific styling migrated/replaced by EventLog styling. |
| ui-rs/src/components/EventLog/index.js | Adds index export for the new shared EventLog component. |
| ui-rs/src/components/EventLog/formatError.js | Adds a shared error/problem formatter used by EventLog summary/detail views. |
| ui-rs/src/components/EventLog/EventLogRow.js | Adds row rendering logic (title/summary/time/status) and expandable details. |
| ui-rs/src/components/EventLog/EventLogDetails.js | Updates/migrates details view to support filter highlighting and shared error formatting. |
| ui-rs/src/components/EventLog/EventLog.test.js | Adds tests for action/actor/message extraction and filter/no-match behavior. |
| ui-rs/src/components/EventLog/EventLog.js | Implements the shared log container with filtering and match counts. |
| ui-rs/src/components/EventLog/EventLog.css | Adds styling for the shared EventLog card, filter controls, and entry rows. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
skomorokh
marked this pull request as ready for review
August 7, 2026 22:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.