Improve sorting in resolved concept sets and fixup Certoparin concept set#5
Open
scymtym wants to merge 4 commits into
Open
Improve sorting in resolved concept sets and fixup Certoparin concept set#5scymtym wants to merge 4 commits into
scymtym wants to merge 4 commits into
Conversation
So that the order is deterministic if two concepts have the same name.
* Change category from Medication to Drug to match similar concept sets * Add "fr" translation by copying from a similar concept set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
resolve.pyto sort concepts by concept name and concept id instead of just the former so that concepts with identical names are sorted deterministicallyFixup for Certoparin changes in Add concept sets for Quality Benchmarking Dashboards (project 5) #4:
Change category from Medication → Drug and Anticoagulant → Anticoagulants to match similar concept sets
Add "fr" translation by copying from a similar concept set
Re-resolve to fix ordering
Re-resolve and re-build with the changes sorting and Certoparin changes