ci: pin ruff-action to 0.15.16 - #156
Merged
Merged
Conversation
The Ruff Action had no version pin, so it always installs "latest" ruff. ruff 0.16.0 fails CI on files unrelated to any given PR's diff — it added CPY001 (missing copyright notice) and started flagging PLR0917 (too-many-positional-arguments) under this repo's `select = ["ALL"]" config, neither of which the existing codebase satisfies. This makes CI fail nondeterministically depending only on when a PR happens to trigger a fresh ruff install, not on the PR's actual changes. Pinning to 0.15.16 (the version used by the last known-green CI run, commit f20d445) restores a clean, reproducible `ruff check`.
indykoning
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
astral-sh/ruff-action@v3) has noversioninput, so it always installs whatever is currently "latest."ruff 0.16.0fails CI on files unrelated to any given PR's diff — it flagsCPY001(missing copyright notice) andPLR0917(too-many-positional-arguments) under this repo'sselect = ["ALL"]config, neither of which the existing codebase (unrelated to any specific PR) satisfies.exceptions.py/tests/.0.15.16— the version used by the last known-green CI run (f20d445) — restores a clean, reproducibleruff check.Test plan
ruff==0.15.16 check ./growattServerlocally against currentmaster— all checks pass.ruff==0.16.0(unpinned/"latest") reproduces the CI failure locally, confirming the version bump is the cause, not any code change.