docs: require https for the detector's address - #15
Merged
Conversation
The detector's ingress sets allowInsecure false, so it answers plain HTTP with a redirect rather than serving it. A client that follows a 301 turns the POST into a GET, and the endpoint rejects that with 405 Method Not Allowed -- the URL is right, the client is working, the request arrives, and the verb has been changed underneath it by the transport. The template carries a placeholder, so nothing in the repository was wrong; the requirement simply was not written down anywhere it would be read while substituting one. It is now stated at the point of substitution and recorded in the runbook alongside the other failure this redirect causes.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request documents that detector endpoints must use HTTPS. It explains HTTP redirect behavior, including POST-to-GET conversion and resulting ChangesDetector HTTPS requirement
Estimated code review effort: 1 (Trivial) | ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The detector's ingress sets
allowInsecure: false, so it answers plain HTTP with a redirect rather than serving it. A client that follows a301turns the POST into a GET, and the endpoint rejects that with405 Method Not Allowed— the URL is right, the client is working, the request arrives, and the verb has been changed underneath it by the transport.Observed in production:
After switching the address to
https://, the same screening succeeded in seven seconds.Docs only — the template carries a placeholder, so nothing in the repository was wrong. What was missing was the requirement, written where someone substituting a value would read it.
Summary by CodeRabbit
405 Method Not Allowedresponses when POST requests are converted to GET requests.