Skip to content

docs: require https for the detector's address - #15

Merged
inesaranab merged 1 commit into
mainfrom
fix/detector-url-https
Aug 11, 2026
Merged

docs: require https for the detector's address#15
inesaranab merged 1 commit into
mainfrom
fix/detector-url-https

Conversation

@inesaranab

@inesaranab inesaranab commented Aug 11, 2026

Copy link
Copy Markdown
Owner

The detector's ingress sets allowInsecure: false, so it answers plain HTTP with a redirect rather than serving it. A client that follows a 301 turns the POST into a GET, and the endpoint rejects that with 405 Method Not Allowed — the URL is right, the client is working, the request arrives, and the verb has been changed underneath it by the transport.

Observed in production:

19:43:16  detector_ready  attempt 4, waited_s: 716
19:43:18  API call failed on attempt 1: Error code: 405 - {'detail': 'Method Not Allowed'}

After switching the address to https://, the same screening succeeded in seven seconds.

Docs only — the template carries a placeholder, so nothing in the repository was wrong. What was missing was the requirement, written where someone substituting a value would read it.

Summary by CodeRabbit

  • Documentation
    • Clarified that the detector endpoint must be accessed over HTTPS.
    • Documented redirect behavior, including possible 405 Method Not Allowed responses when POST requests are converted to GET requests.
    • Updated deployment configuration guidance to require an HTTPS base URL.

The detector's ingress sets allowInsecure false, so it answers plain HTTP with a
redirect rather than serving it. A client that follows a 301 turns the POST into
a GET, and the endpoint rejects that with 405 Method Not Allowed -- the URL is
right, the client is working, the request arrives, and the verb has been changed
underneath it by the transport.

The template carries a placeholder, so nothing in the repository was wrong; the
requirement simply was not written down anywhere it would be read while
substituting one. It is now stated at the point of substitution and recorded in
the runbook alongside the other failure this redirect causes.
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a0e199db-6eab-427e-a8f5-6347e929e6e5

📥 Commits

Reviewing files that changed from the base of the PR and between 1f7fdd6 and e5140a8.

📒 Files selected for processing (2)
  • infra/gemma/README.md
  • infra/worker-job.yaml

📝 Walkthrough

Walkthrough

The pull request documents that detector endpoints must use HTTPS. It explains HTTP redirect behavior, including POST-to-GET conversion and resulting 405 Method Not Allowed responses.

Changes

Detector HTTPS requirement

Layer / File(s) Summary
Document HTTPS endpoint requirements
infra/gemma/README.md, infra/worker-job.yaml
The documentation specifies an https:// detector URL and describes failures caused by HTTP redirects, including POST-to-GET conversion and 405 Method Not Allowed responses.

Estimated code review effort: 1 (Trivial) | ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/detector-url-https

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@inesaranab
inesaranab merged commit e4b4b60 into main Aug 11, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant