fix(deps): secure legacy request multipart boundaries - #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retired development dependency
requestpinsform-datato vulnerable 2.3.x. With a predictableMath.random, two fresh forms generate the same multipart boundary. Add a scoped npm override selecting form-data 2.5.6 for request, fixing critical alert #223 and the later boundary advisory #324 while retaining its current API major.Add
npm run check:multipartto full verification and both CI jobs. It resolves the actual form-data used by request, reproduces predictable boundary generation, and exercises an HTTP text/binary upload against a local server, including headers, boundary framing and content length. Document why the override exists and when to remove it.Validation:
npm run verifypassed, including 42 viewer tests, lint, library/demo/SSR builds, default-export and hydration checks, multipart upload and package dry run.git diff --checkpassed; rebase onto the merged Babel batch retained the exact tested tree.Predictable-boundary advisory, follow-up advisory. Other request/jsdom advisories remain separate maintenance work; this PR does not claim those obsolete parents are fully secure.