Skip to content

fix(boilerplate): remove interop definition for FlashList #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frankcalise merged 1 commit into from
Nov 13, 2024
Merged

fix(boilerplate): remove interop definition for FlashList #2838

frankcalise merged 1 commit into from
Nov 13, 2024

Conversation

@frankcalise
Copy link
Contributor

@frankcalise frankcalise commented Nov 9, 2024

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • yarn lint eslint checks pass with new code, if relevant
  • yarn format:check prettier checks pass with new code, if relevant
  • README.md (or relevant documentation) has been updated with your changes
  • If this affects functionality there aren't tests for, I manually tested it, including by generating a new app locally if needed (see docs).

Describe your PR

  • Removes the interop fabric definition for FlashList, since the New Architeture is now supported by that library
  • I believe this is automatically handled by Expo now anyway

Example log

warn The "project.ios.unstable_reactLegacyComponentNames" config option is not necessary anymore for React Native 0.74 and does nothing. Please remove it from the "react-native.config.js" file.
warn The "project.android.unstable_reactLegacyComponentNames" config option is not necessary anymore for React Native 0.74 and does nothing. Please remove it from the "react-native.config.js" file

@frankcalise frankcalise merged commit b368bcb into master Nov 13, 2024
@frankcalise frankcalise deleted the fix/remove-flashlist-interop branch November 13, 2024 15:49
infinitered-circleci pushed a commit that referenced this pull request Nov 27, 2024
@semantic-release-bot
chore(release): 10.0.5 [skip ci]
ff71baa 
## [10.0.5](v10.0.4...v10.0.5) (2024-11-27)

### Bug Fixes

* **boilerplate:** remove interop definition for FlashList ([#2838](#2838) by [@frankcalise](https://github.com/frankcalise)) ([b368bcb](b368bcb))
* **boilerplate:** update app.tsx useEffect ([#2850](#2850) by [@objective](https://github.com/objective)See) ([2886487](2886487))
* **cli:** component generator template off in expo-router ([#2854](#2854) by [@frankcalise](https://github.com/frankcalise)) ([95f7642](95f7642))
* **cli:** include ajv in devDependencies for Expo Router and npm ([#2842](#2842) by [@coolsoftwaretyler](https://github.com/coolsoftwaretyler)) ([6baf76b](6baf76b))
@infinitered-circleci
Copy link
Collaborator

infinitered-circleci commented Nov 27, 2024

🎉 This PR is included in version 10.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markrickert markrickert markrickert approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frankcalise @infinitered-circleci @markrickert