Add insecure ssl support to connect to kapacitor#2140
Merged
Conversation
|
Something still seems broken, whether I add Kapacitor from the cmdline using In chronograf's log: In Kapacitor's log: |
|
@goller any hints here? :) |
Contributor
Author
|
@binary0111 hey there! Just before I went on vacation @desa and I were looking at that new sources code ... it doesn’t quite respect the changes I made in this pr but it should. We will need to fix it.
Would you open a new issue about the new sources option ?
… On Dec 26, 2017, at 9:25 PM, binary0111 ***@***.***> wrote:
@goller any hints here? :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
Author
|
Ah yes, thank you @binary0111 ! I've just added PR #2689 to fix this. |
|
Thanks @goller! Much Appreciated :) |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connect #2139
The problem
No support for insecure, self-signed certificates for https connections to kaapcitor
The Solution
Added
insecureSkipVerifyto the kapacitor REST interface