fix(influxdb-v1): remove retired _internal stat fields from measurements-internal - #7731
Open
jstirnaman wants to merge 4 commits into
Open
fix(influxdb-v1): remove retired _internal stat fields from measurements-internal#7731jstirnaman wants to merge 4 commits into
jstirnaman wants to merge 4 commits into
Conversation
…nts-internal httpd.valuesWrittenOK, write.pointsWrittenOK, write.valuesWrittenOK, and write.subWriteDrop no longer exist in InfluxDB v1's _internal measurements. Engineering confirmed on #7684 that httpd.valuesWrittenOK was declared but never emitted (removed in 1.9.0), write.subWriteDrop was removed for 1.10.0, and the two write.*WrittenOK fields never existed. hh_database is confirmed to exist in Enterprise's hinted-handoff service, so it stays documented without the prior "unconfirmed" caveat. Closes #7684
Contributor
Vale Style Check Results
Errors (blocking)
Warnings (12)
❌ Check failed — fix 10 error(s) before merging. |
Contributor
Release version check
💡 Badge new features with the versionDocumenting a new feature? Add a version badge in the page frontmatter — the
For inline version text, use |
github-actions
Bot
added
product:shared
Contributor
🔗 Link Check Results — Link Check Bot❌ 10 broken link(s) found — fix them before merging.
Broken Links
|
| Source File | URL | Issue |
|---|---|---|
content/enterprise_influxdb/v1/administration/monitor/measurements-internal/_index.md |
https://support.influxdata.com/ | Network error: SSL certificate not trusted. Use --insecure if site is trusted (e… |
content/influxdb/v1/about_the_project/release-notes/_index.md |
file:///home/runner/work/docs-v2/docs-v2/public/influxdb/v1/api/debug | File not found. Check if file exists and path is correct: File not found. Check … |
content/influxdb/v1/about_the_project/release-notes/_index.md |
file:///home/runner/work/docs-v2/docs-v2/public/influxdb/v1/api/debug | File not found. Check if file exists and path is correct: File not found. Check … |
content/influxdb/v1/about_the_project/release-notes/_index.md |
file:///home/runner/work/docs-v2/docs-v2/public/influxdb/v1/api/buckets-v2-compatible | File not found. Check if file exists and path is correct: File not found. Check … |
content/influxdb/v1/about_the_project/release-notes/_index.md |
file:///home/runner/work/docs-v2/docs-v2/public/influxdb/v1/api/delete-v2-compatible | File not found. Check if file exists and path is correct: File not found. Check … |
content/influxdb/v1/about_the_project/release-notes/_index.md |
file:///home/runner/work/docs-v2/docs-v2/public/influxdb/v1/api/query | File not found. Check if file exists and path is correct: File not found. Check … |
content/influxdb/v1/about_the_project/release-notes/_index.md |
file:///home/runner/work/docs-v2/docs-v2/public/influxdb/v1/api/delete-v2-compatible | File not found. Check if file exists and path is correct: File not found. Check … |
content/influxdb/v1/about_the_project/release-notes/_index.md |
file:///home/runner/work/docs-v2/docs-v2/public/influxdb/v1/api/buckets-v2-compatible | File not found. Check if file exists and path is correct: File not found. Check … |
content/influxdb/v1/about_the_project/release-notes/_index.md |
file:///home/runner/work/docs-v2/docs-v2/public/influxdb/v1/api/debug | File not found. Check if file exists and path is correct: File not found. Check … |
content/influxdb/v1/about_the_project/release-notes/_index.md |
https://support.influxdata.com/ | Network error: SSL certificate not trusted. Use --insecure if site is trusted (e… |
content/influxdb/v1/administration/monitor/measurements-internal/_index.md |
https://support.influxdata.com/ | Network error: SSL certificate not trusted. Use --insecure if site is trusted (e… |
Full details: workflow run summary and artifact. Last updated: 2026-09-04 16:47:45 UTC
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The v1.8.3 release-note bullet still claims “track number of values” but now links to #httpd, which doesn’t contain a values-written stat; it should be corrected to point to (and describe) pointsWrittenOK.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Removes _internal stat fields that engineering confirmed are retired or never emitted from the shared InfluxDB v1 internal-monitoring documentation, and updates a v1.8.3 release-notes link to avoid pointing at a removed anchor.
Changes:
- Removed
httpd.valuesWrittenOK,write.pointsWrittenOK,write.valuesWrittenOK, andwrite.subWriteDropfrom the_internalmeasurements reference (including TOC entries and field sections). - Removed the prior inline “VERIFY (live instance)” caveat block now that #7684 has been resolved.
- Updated a v1.8.3 release-note link away from the removed
#valueswrittenokanchor.
File summaries
| File | Description |
|---|---|
| content/shared/influxdb-v1/administration/monitor/measurements-internal.md | Drops retired/never-emitted _internal fields (and associated TOC entries) from the shared v1 monitoring reference. |
| content/influxdb/v1/about_the_project/release-notes.md | Adjusts the v1.8.3 release-note link target to avoid a removed anchor in measurements-internal. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
📦 PR Preview — Preview Bot
Changed pages (3)Preview auto-deploys on push. Will be cleaned up when PR closes. |
Co-authored-by: jstirnaman <212227+jstirnaman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7684
What changed
In
content/shared/influxdb-v1/administration/monitor/measurements-internal.md:httpd.valuesWrittenOKfrom the table of contents and thehttpdsection.write.pointsWrittenOKandwrite.valuesWrittenOKfrom the table of contents and thewritesection.write.subWriteDropfrom the table of contents and thewritesection.<!-- VERIFY (live instance) -->comment that a prior PR (fix(platform): verify InfluxDB _internal fields against live v1.13.0 #7685) added, including its "unconfirmed" note abouthh_database.hh_databaseitself stays documented; only the caveat is gone.In
content/influxdb/v1/about_the_project/release-notes.md:measurements-internal/#valueswrittenok. That anchor no longer exists once bothvaluesWrittenOKheadings are removed, so the link now points tomeasurements-internal/#httpd.Why
Issue #7684 asked engineering to confirm whether five
_internalstat fields still exist in InfluxDB v1. @davidby-influx confirmed on the issue thread:httpd.valuesWrittenOK— declared inservices/httpd/service.gobut never emitted; its use was removed in 1.9.0.write.subWriteDrop— removed for 1.10.0.write.pointsWrittenOKandwrite.valuesWrittenOK— never existed.httpd.pointsWrittenOKis the closest analog and is already documented.hh_database— confirmed to exist in the Enterprise hinted-handoff service, so it stays documented.This content is shared between
influxdb/v1andenterprise_influxdb/v1throughcontent/shared/, so the fix applies to both products in one file.Impact
Readers of the InfluxDB v1 and Enterprise v1 internal-monitoring documentation will no longer see four fields that don't exist in current InfluxDB v1 releases. The release-notes link to
measurements-internalno longer 404s on the removed anchor.Verification
No live-instance verification was run in this change. The removals are based on direct inspection of the InfluxDB source at commit
8a2663add71ed729e1cc6e465f754e8beea8d541:services/httpd/service.godeclaresstatValuesWrittenOKbut noStatisticsmap emits it; onlystatPointsWrittenOKis emitted, inhandler.go.coordinator/points_writer.golists the completewritemodule stat key set (req,pointReq,pointReqLocal,writeOk,writeDrop,writeTimeout,writeError,subWriteOk) — nopointsWrittenOK,valuesWrittenOK, orsubWriteDrop.hh_database's continued existence was confirmed by engineering against the private Enterprise hinted-handoff service source, cited in the issue thread.Confirmed by grep that the shared source file no longer contains any of the four removed field names or the VERIFY note, and that
httpd.pointsWrittenOKandhh_databaseremain documented.Out of scope: the four retired fields are still described on
content/telegraf/v1/input-plugins/influxdb.md, which syncs from the upstream Telegraf plugin README and isn't editable in this repository. That needs a separate upstream fix.Checklist
npx hugo --quiet)Note
The source issue was chosen as a test of the docs-tooling triage-pipeline end-to-end.
This PR was generated by the pipeline.