feat(processing_engine): Attach a node id to the processing engine and triggers for multi-node support compatibility.#26136
Merged
jacksonrnewhouse merged 1 commit intomainfrom Mar 13, 2025
Conversation
…d triggers for multi-node support compatibility.
pauldix
approved these changes
Mar 13, 2025
hiltontj
reviewed
Mar 14, 2025
Comment on lines
+382
to
+388
| if trigger.node_id != self.node_id { | ||
| error!( | ||
| "Not running trigger {}, as it is configured for node id {}. Multi-node not supported in core, so this shouldn't happen.", | ||
| trigger_name, trigger.node_id | ||
| ); | ||
| return Ok(()); | ||
| } |
Contributor
There was a problem hiding this comment.
Ah, I see this may be a place where a ProcessingEngineManager trait could be useful. Perhaps my removing that was pre-emptive...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Enterprise version triggers will be tied to a specific node. This change ensures a smooth upgrade path from Core to Enterprise.