Skip to content

feat: add query parameters to tasks contract that fulfill the pagination, filtering, and sorting epic#298

Merged
yquansah merged 2 commits intomasterfrom
yq-add-tasks-documentation
Apr 29, 2022
Merged

feat: add query parameters to tasks contract that fulfill the pagination, filtering, and sorting epic#298
yquansah merged 2 commits intomasterfrom
yq-add-tasks-documentation

Conversation

@yquansah
Copy link
Copy Markdown
Contributor

@yquansah yquansah commented Apr 4, 2022

There has been an effort to support multiple changes on the server side for support of pagination, filtering, and sorting of tasks on the server side, to get away from doing that on the client side.

This PR adds some documentation for the parameters that were added for query on the API.

Copy link
Copy Markdown
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment/question about these parameters being required

Comment thread src/cloud/paths/tasks.yml
schema:
type: string
enum:
- name
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we mark these as not required so that the UI not sending them over won't change current behavior?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoorayimhelping Yes, I will do that!

@gavincabbage
Copy link
Copy Markdown
Contributor

@yquansah Are we good to merge this?

@yquansah
Copy link
Copy Markdown
Contributor Author

@gavincabbage we are good to merge this. This PR slipped through the cracks.

@yquansah yquansah merged commit d44c651 into master Apr 29, 2022
@yquansah yquansah deleted the yq-add-tasks-documentation branch April 29, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants