Skip to content

feat: add query parameters to tasks contract that fulfill the pagination, filtering, and sorting epic #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yquansah merged 2 commits into from
Apr 29, 2022
Merged

feat: add query parameters to tasks contract that fulfill the pagination, filtering, and sorting epic #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2b35ad
feat: add query parameters to tasks contract that fulfill the paginat…
yquansah Apr 4, 2022
5abd986
chore: mark the added parameters as not required
yquansah Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions contracts/cloud-diff.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 23 additions & 0 deletions contracts/cloud.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions contracts/cloud.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions contracts/ref/cloud.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions src/cloud/paths/tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,22 @@ get:
maximum: 500
default: 100
description: The non-zero number of tasks to return
- in: query
name: offset
required: false
schema:
type: integer
minimum: 0
default: 0
description: The number of records to skip
- in: query
name: sortBy
description: Field that records should be sorted by
required: false
schema:
type: string
enum:
- name
Copy link
Copy Markdown
Contributor

@hoorayimhelping hoorayimhelping Apr 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we mark these as not required so that the UI not sending them over won't change current behavior?

Copy link
Copy Markdown
Contributor Author

@yquansah yquansah Apr 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoorayimhelping Yes, I will do that!

- in: query
name: type
description: Type of task, unset by default.
Expand Down