ci(config): Consolidate versioning - #423
Merged
Merged
Conversation
Consolidate versioning to a single managed version file. Also enforce this at the CI by using a script to confirm all dll's have the correct version information. This addresses part of informedica#387
Contributor
Greptile SummaryThis PR consolidates assembly versioning into one managed file. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "Merge branch 'master' into consolidate-v..." | Re-trigger Greptile |
…ared version The top of all three files says `// Auto-Generated by FAKE; do not edit` The problem is this warning that stopped being true the moment these libraries were merged into the monorepo. Git blame points back to commit `0df3c28f` (“chore: added all genpres source code”), which pulled in *Informedica.GenUnits.Lib* and *Informedica.Utils.Lib* from their old standalone repos. Those repos apparently had FAKE pipelines that really did regenerate `AssemblyInfo.fs` on each release, which explains the 2021 timestamps, old commit hashes, and versions stuck at 1.0.2/1.0.0. This repo’s `Build.fs` doesn’t reference `Fake.DotNet.AssemblyInfo` at all, so the comment has been confidently promising automation that soesn't exist. Meanwhile, the files were quietly clashing with the SDK’s own `GenerateAssemblyInfo`, which writes the same attributes into `obj/` from `Directory.Build.props`. Two competing sets of one-shot assembly attributes going into the same DLL doesn’t trigger an error in either compiler, so the final result depended on a reace condition, which happened to be caught between my local rebuild and CI’s clean-runner build. In other words: the comment meant to prevent subtle, environment-dependent breakage ended up *causing* exactly that! :-)
Collaborator
Author
|
@halcwb Notice |
halcwb
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate versioning to a single managed version file. Also enforce this at the CI by using a script to confirm all dll's have the correct version information.
This addresses part of #387