Skip to content

fix(github): don't fail CI when publishing test results is blocked - #430

Merged
halcwb merged 1 commit into
informedica:masterfrom
7sharp9:issue_425
Aug 2, 2026
Merged

fix(github): don't fail CI when publishing test results is blocked#430
halcwb merged 1 commit into
informedica:masterfrom
7sharp9:issue_425

Conversation

@7sharp9

@7sharp9 7sharp9 commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Dependabot and fork PRs get a read-only GitHub token that can't post test-result annotations, which was failing otherwise good builds.

If we make that step non-blocking so a permissions issue with a reporting step doesn't mask a good build. Fixes #425

Dependabot and fork PRs get a read-only GitHub token that can't post test-result annotations, which was failing otherwise good builds.

If we make that step non-blocking so a permissions issue with a reporting step doesn't mask a good build.
# regardless of any `permissions:` blocks declared, so this step 403s on those runs. Test results are still
# in the build log so don't let that fail a good build due to this step.
if: always() && runner.os == 'Linux'
continue-on-error: true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Limit reporting error suppression

continue-on-error applies to every invocation, including trusted pushes and same-repository pull requests where result publication is expected to work. A non-permission failure in this sole publication step will therefore leave annotations absent while CI remains green; limit suppression to the restricted Dependabot and fork contexts.

Knowledge Base Used: Build and Versioning

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Makes GitHub test-result publication non-blocking so permission failures on Dependabot and fork pull requests do not fail otherwise successful builds.

  • Documents why restricted GITHUB_TOKEN contexts can prevent result publication.
  • Allows the Linux test-result publishing step to fail without failing the job.

Confidence Score: 4/5

The PR is safe to merge, with a non-blocking concern that reporting failures are suppressed beyond the restricted-token contexts targeted by the change.

Test execution remains blocking, but unconditional error suppression allows the sole result-publication step to fail silently on trusted pushes and same-repository pull requests.

Files Needing Attention: .github/workflows/build.yml

Important Files Changed

Filename Overview
.github/workflows/build.yml Makes test-result publication non-blocking for all runs, which also suppresses reporting failures in trusted contexts.

Reviews (1): Last reviewed commit: "fix(github): don't fail CI when publishi..." | Re-trigger Greptile

@halcwb
halcwb merged commit 0218077 into informedica:master Aug 2, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publishing test result fails in the CI pipeline

2 participants