Skip to content

Add fixed-bottom to footer#191

Merged
infotexture merged 5 commits intoinfotexture:developfrom
jason-fox:feature/bottom
Apr 10, 2024
Merged

Add fixed-bottom to footer#191
infotexture merged 5 commits intoinfotexture:developfrom
jason-fox:feature/bottom

Conversation

@jason-fox
Copy link
Collaborator

@jason-fox jason-fox commented Mar 27, 2024 •
edited
Loading

Fixes #190

When using bootstrap 5, flexbox can be used to achieve desired effect:

<body class="d-flex flex-column min-vh-100">
    <header>HEADER</header>
    <content>CONTENT</content>
    <footer class="mt-auto"></footer>
</body>

@jason-fox jason-fox added the bug label Mar 27, 2024
@jason-fox jason-fox requested a review from infotexture March 27, 2024 16:58
@infotexture infotexture changed the title Add fixed-bottom to footer. Add fixed-bottom to footer Apr 10, 2024
@infotexture
Fix indentation
ac06cf7 
Amends bf2ff49.

Signed-off-by: Roger Sheen <roger@infotexture.net>
infotexture
infotexture approved these changes Apr 10, 2024
View reviewed changes
Copy link
Owner

@infotexture infotexture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@infotexture infotexture merged commit 0171fa4 into infotexture:develop Apr 10, 2024
@jason-fox jason-fox deleted the feature/bottom branch April 11, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@infotexture infotexture infotexture approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Footer sticking up in some cases

2 participants

@jason-fox @infotexture