[IMP] l10n_ar_website_sale_ux: refresh tax-excluded price on variant change - #465
Closed
fw-bot-adhoc wants to merge 1 commit into
Closed
[IMP] l10n_ar_website_sale_ux: refresh tax-excluded price on variant change#465fw-bot-adhoc wants to merge 1 commit into
fw-bot-adhoc wants to merge 1 commit into
Conversation
Contributor
|
|
Author
|
@JrAdhoc @augusto-weiss cherrypicking of pull request #464 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
you can use 
…change The tax-excluded price (RG 4/2025) was rendered server-side but stayed stale when the customer switched variant on the product page. Extend the website_sale VariantMixin to update it on combination change, mirroring how the regular price is refreshed. X-original-commit: 4a6601a
JrAdhoc
force-pushed
the
18.0-17.0-t-69616-jr-6918-fw
branch
from
July 1, 2026 14:28
70edecc to
da53ab1
Compare
Contributor
|
@roboadhoc r+ nobump |
roboadhoc
pushed a commit
that referenced
this pull request
Jul 1, 2026
…change The tax-excluded price (RG 4/2025) was rendered server-side but stayed stale when the customer switched variant on the product page. Extend the website_sale VariantMixin to update it on combination change, mirroring how the regular price is refreshed. closes #465 X-original-commit: 4a6601a Signed-off-by: Augusto Weiss <awe@adhoc.com.ar>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On the product page, the Precio Sin Impuestos Nacionales (RG 4/2025) value is computed server-side in
_get_additionnal_combination_infoand rendered once, but it was not updated when the customer selected a different variant — only the regular price refreshed, leaving a stale tax-excluded amount.How
website_saleWebsiteSalepublic widget (newstatic/src/js/website_sale.js) and override_onChangeCombinationto rewrite the tax-excluded amount fromcombination.price_tax_excludedon every combination change, using_priceToStrfor currency formatting — the same way the core refreshes the regular price. We patch the widget rather thanVariantMixinbecauseWidget.extend(VariantMixin, ...)copies the mixin methods into the prototype at definition time, so a later mixin patch from this asset never reaches the instance.o_l10n_ar_price_tax_excludedanchor class to the<small>wrapper in theproduct_priceinherit so the JS can target the inner.oe_currency_value.web.assets_frontendand bump version to 17.0.1.5.0.No Python changes: the per-combination
price_tax_excludedwas already provided. The JS is guarded so it only acts when the value is present (AR + tax-included websites).Test plan
On an AR website with
show_line_subtotals_tax_selection = 'tax_included':Task: 69616
Forward-Port-Of: #464