-
Notifications
You must be signed in to change notification settings - Fork 13
Merge Release #3765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merge Release #3765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve error message/stack trace on MigrateCommand storage
update codeowners file and dependabot config
… is actually contained. (#3750) This avoids cases, where dates are improperly merged for multiple connectors
* adds warning to CachedStore, if there are duplicate keys (This can be due to seriliaziation errors - not misues of the underlying Store) --------- Co-authored-by: MT <12283268+thoniTUB@users.noreply.github.com>
Implements substring logic for SelectFilter(s) and MappableSingleColumnSelect derivates also merges SingleSelectFilter logic to use MultiSelectFilterNode under the hood with Singleton-Set, as that is probably exactly as fast in our applications.
Reworks all API Endpoints that used resolved Id-References on-the-fly. We now explicitly have to resolve all Ids. This also introduces Id#getDomain, which is the storage or Storage provider of an Id (i.e. the Domain on which it can be resolved). Ids without domains can exist as a kind of query into the store, but this should be avoided. Instead they should be derived from their corresponding object. Ids are strictly separated into the MetaStorage domain and the Namespaced domain: * MetaStorage containing user dependent information or configuration * Namespaced relates to Datasets and Concept configuration. NamespacedIds and -Objects try to always delegate to their DatasetId as root for any Domain related tasks. MetaIds and -Objects usually hold their own domain as there are no obvious roots. --- We refactored the API away from explicit object usage to reduce implicit conversions, but also to make it easier to use with openapi specs. Alongside, we also cleaned up the usage of resolve and getId, where they sometimes would be followed by each other in close succession, making them meaningless. We also tried refactoring BucketManager#create, though it still has some circular dependency with WorkerStorage and does IO at inopportune times in startup.
warn if an encoded string contains unencoded characters
ignores WorkerInformation#entityBucketSize
Remove initial filter value loading upon opening a concept node
Refactors BucketManager to avoid heavy IO in #create: Now only works on Ids (i.e. Store-keys) which is much faster and avoids circular dependencies with WorkerStorage. We also create a new Entity2Bucket store, tracking the existence of entities on Shards.
adds validation of inserted Table against SQL Server
Reintegrate Main
We cannot rely on the injection of a specific namespaced storage because we have "global" object mappers attached to mina that are not bound to a specific namespace. Where possible, we inject the storage directly (API, storage itself)
fix npe on missing JacksonInject in InterToExternMapper
thoniTUB
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.