Skip to content

refactor(frontend): concept trees, query runner, query node editor on tailwind-variants - #3993

Merged
Kadrian merged 1 commit into
refactor/tailwind-small-dirsfrom
refactor/tailwind-query-editor
Sep 2, 2026
Merged

refactor(frontend): concept trees, query runner, query node editor on tailwind-variants#3993
Kadrian merged 1 commit into
refactor/tailwind-small-dirsfrom
refactor/tailwind-query-editor

Conversation

@Kadrian

@Kadrian Kadrian commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Emotion → tailwind migration, PR 2/6: the query-editing core (31 files).

(concept-trees, query-runner, query-node-editor — stacked on #3992, stack overview there)

Main change

  • every styled() block → tv(); truly dynamic values (tree depth * 15px indents, drag preview sizes) stay inline style
  • QueryRunningSpinner reads the spinner image via useAppTheme(); built-in animate-spin replaces the custom keyframes (identical)

Worth a closer look

  • QueryRunnerButton: descendant hover (&:hover .query-runner-label) → named group group/runner + group-hover/runner:; the marker class is gone
  • DownloadResultsDropdownButton: nested button {…} selector → [&_button]: variants
  • duplicate styled blocks collapsed into variants (error/success icons in both upload modals, error/not-found text states)
  • a11y: two clickable non-buttons keep onClick + biome-ignore/TODO instead of invented roles

Checks: biome, tsc, vitest, vite build green; generated css spot-checked (named group-hover, [&_button], bg-size-[30px]).

@Kadrian
Kadrian force-pushed the refactor/tailwind-query-editor branch from f428c3d to eac585b Compare September 2, 2026 13:27
@Kadrian
Kadrian merged commit 2412e61 into develop Sep 2, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants