Skip to content

Reset the child signal mask before exec #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guillerodriguez merged 1 commit into from
Aug 3, 2026
Merged

Reset the child signal mask before exec #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions native/jni/native-lib/cpproc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,7 @@ static void child_process(char * const *commandLine,
const char *path, char **sh_argv, const char *wd,
int maxfd)
{
sigset_t sigmask;
int errnum;

close(fail_fds[0]);
Expand All @@ -485,8 +486,16 @@ static void child_process(char * const *commandLine,
if (mark_nonstd_fds_cloexec(maxfd) < 0)
goto child_error;

if (wd == NULL || chdir(wd) == 0)
cp_execvpe(commandLine[0], commandLine, newEnviron, path, sh_argv);
if (wd != NULL && chdir(wd) != 0)
goto child_error;

/* Reset the signal mask so that the executed program starts with all
signals unblocked. */
sigemptyset(&sigmask);
if (sigprocmask(SIG_SETMASK, &sigmask, NULL) < 0)
goto child_error;

cp_execvpe(commandLine[0], commandLine, newEnviron, path, sh_argv);

child_error:
/* Child setup or exec itself failed; send our errno to the parent */
Expand Down
Loading