Open
Conversation
- Use application-level error codes instead of reserved JSON-RPC range - Fix doc example codes that looked like HTTP status codes - Add IntoErrorPayload impl for core::convert::Infallible - Clarify that ErrData associated type is required in trait docs - Refactor magic8ball match to take ownership, removing unnecessary clone Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
opted not to include a rename of ErrData as the compiler enforces correct usage, and there are >50 places to update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[-32099, -32000]in examples and doc testsimpl IntoErrorPayload for core::convert::InfallibleErrDataassociated type must also be specifiedinto_error_payloadmatch to takeselfby value, removing unnecessary.clone()Addresses non-blocking nits from @0xfmac on #42.
Test plan
cargo t -p ajj— all 25 unit + 20 doc-tests passcargo clippy --all-features --all-targetscleancargo clippy --no-default-features --all-targetsclean🤖 Generated with Claude Code