feat(perms): add SSE subscribe_bundles to BuilderTxCache#131
Merged
Conversation
Fraser999
requested changes
Apr 2, 2026
| } | ||
|
|
||
| const BUNDLES: &str = "bundles"; | ||
| #[cfg(feature = "sse")] |
Contributor
There was a problem hiding this comment.
Seems like we're missing this feature from the manifest. I expect we want something like:
sse = ["perms", "signet-tx-cache/sse"]
Member
Author
There was a problem hiding this comment.
yep i messed up a conflict marker here :D
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ada1356 to
f6dfdd3
Compare
Fraser999
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
ssecargo feature that enablessignet-tx-cache/sse, gated behindpermsso SSE deps (eventsource-stream,serde_json) stay opt-insubscribe_bundles()toBuilderTxCachewhich connects to the/bundles/feedSSE endpoint with bearer auth, using the upstreamsubscribe_innerhelper to avoid code duplicationSharedTokenand passes it asSome(&secret)— unlikesubscribe_transactions/subscribe_orderswhich passNoneTest plan
cargo check --features ssecompilescargo check --features permsstill compiles (no regression)🤖 Generated with Claude Code