chore: bump signet-sdk to 0.18.0 (for real this time)#276
Open
Evalir wants to merge 1 commit into
Open
Conversation
The previous bump PR (#274) landed with title claiming 0.18.0 but content only at 0.17.0 and node-components still on the v0.16.0-rc.10 git tag. This catches the builder up to current published versions and clears the cross-repo git pin. Version bumps: - init4-bin-base 0.20.0 -> 0.21.0 - signet-{constants,sim,tx-cache,types,zenith} 0.17.0 -> 0.18.0 - signet-bundle (dev-dep) 0.17.0 -> 0.18.0 Dep source changes: - signet-block-processor and signet-genesis: git tag v0.16.0-rc.10 -> crates.io 0.18.0 (now that node-components publishes to crates.io). - signet-block-processor removed entirely; it was only there for the revm_spec re-export, which was deleted in node-components v0.17.0 when the reth dep was dropped (#93 there). - signet-evm 0.18.0 added: replacement for revm_spec lives there as EthereumHardfork::active_hardforks(...).spec_id(). Source migration in SignetCfgEnv: - revm_spec(chainspec, timestamp) replaced with EthereumHardfork::active_hardforks(&chainspec.genesis().config, block_number, timestamp).spec_id(). - SignetCfgEnv now carries block_number alongside timestamp; the new helper needs both. Threaded through 5 call sites. - Added SignetCfgEnv::from_block_env(chain_id, &BlockEnv) so the 4 BlockEnv-derived sites stay one-liners. prep.rs keeps new() since it builds for the next block from a Header. Behavior note: the old revm_spec floored at PRAGUE. The new path reports the actual active spec from the genesis config. For mainnet/parmigiana rollup configs (all forks at timestamp 0) and for current host timestamps (post-Osaka), output is identical. The floor would only have mattered for pre-Prague host timestamps, which no production path here uses. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Re-bumps the signet stack to actually consume 0.18.0. The previous PR (#274) merged with a title claiming 0.18.0 but its content only moved signet-* to 0.17.0 and left
signet-block-processor/signet-genesison thenode-componentsgit tagv0.16.0-rc.10. This catches the builder up and removes the cross-repo git pin.Version bumps
init4-bin-base0.20.0 → 0.21.0signet-{constants,sim,tx-cache,types,zenith}0.17.0 → 0.18.0signet-bundle(dev-dep) 0.17.0 → 0.18.0Dep source changes
signet-block-processorandsignet-genesismove fromnode-components@v0.16.0-rc.10(git) → crates.io0.18.0now that they're published there.signet-block-processoris removed — it was only there forrevm_spec, which was deleted upstream in node-components v0.17.0 when the reth dep was dropped.signet-evm = "0.18.0"added — that's where the replacement helper lives.Source migration in
SignetCfgEnvrevm_spec(chainspec, timestamp)→EthereumHardfork::active_hardforks(&chainspec.genesis().config, block_number, timestamp).spec_id().SignetCfgEnvnow carriesblock_numbernext totimestamp(the new helper needs both for full fork resolution). Threaded through 5 call sites.SignetCfgEnv::from_block_env(chain_id, &BlockEnv)so the 4 BlockEnv-derived sites stay one-liners.prep.rskeepsnew()since it builds for the next block from aHeader.Behavior note
Old
revm_spechad a hard PRAGUE floor; the new path reports whatever the genesis config says is active. Cross-checked against the actualsignet-genesisconfigs:Related Issue
Closes ENG-2235 (carried over from #274).
Testing
cargo clippy --workspace --all-targets --all-features -- -D warningscargo test -p builder --lib tasks::block::cfg(themainnet_cfg_envPRAGUE↔OSAKA spec-resolution test passes)make fmtmake clippymake test