[hackathon] fix(node-tests): adapt test infra to HostNotifier trait#108
Draft
prestwich wants to merge 1 commit intofeat/host-rpcfrom
Draft
[hackathon] fix(node-tests): adapt test infra to HostNotifier trait#108prestwich wants to merge 1 commit intofeat/host-rpcfrom
prestwich wants to merge 1 commit intofeat/host-rpcfrom
Conversation
Replace ExExContext-based test setup with a channel-backed TestHostNotifier, allowing signet-node-tests to compile against the new HostNotifier-generic SignetNodeBuilder API. - Add TestHostNotifier wrapping an unbounded channel - Convert ExExNotification → HostNotification directly (drop reth conversion path in convert.rs) - Supply blob_cacher, ServeConfig, StorageRpcConfig to the builder - Remove reth-exex and reth-node-api deps; keep reth for pool access Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
This was referenced Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestHostNotifierbacked by an unbounded channel, implementingHostNotifierfor integration testsExExNotification→HostNotification<Chain>directly, removing the reth conversion path inconvert.rsSignetTestContextanddb.rsto use the newSignetNodeBuilderAPI (with_notifier,with_blob_cacher,with_serve_config,with_rpc_config)reth-exexandreth-node-apideps fromsignet-node-tests; keepsrethfor pool accessPR 5 of 5 in the host context adapter refactor.
Precursor: #106
Test plan
cargo clippy -p signet-node-tests --all-features --all-targets— cleancargo +nightly fmt --check— cleancargo t -p signet-node-tests -- test_genesis— passescargo t -p signet-node-tests -- test_genesis_allocs— passes🤖 Generated with Claude Code