Conversation
Opens the read transaction before resolving the block ID so that hash→number lookup and subsequent data query share the same MDBX snapshot. Eliminates a race where a reorg between the two transactions could produce inconsistent results. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Header lookup and RevmRead construction now share one MDBX read transaction. This eliminates a race where a reorg between two separate transactions could yield a header from one fork and EVM state from another. Follows the same pattern used by the block-processor crate. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds module-level and struct-level rustdoc explaining Acquire/Release ordering, multi-tag update order, rewind safety, and the race window between tag resolution and storage queries. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds module-level and struct-level rustdoc explaining the two-tier architecture, query routing table, resolve-then-query pattern, cold lag characteristics, and deferred hash-based verification. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
prestwich
force-pushed
the
prestwich/eng-1901-rpc-consistency-docs
branch
from
2c59169 to
c9559ee
Compare
Fraser999
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hot_reader_at_blockto single MDBX transaction — state query endpoints (getBalance,getStorageAt,getCode,getTransactionCount) now resolve block IDs and query data within the same MDBX read transaction, eliminating a race where a reorg between two transactions could produce inconsistent resultsresolve_evm_blockto single MDBX transaction — EVM execution endpoints (eth_call,estimateGas,createAccessList) now fetch the header and construct the revm database from the same MDBX snapshot, following the same pattern used by the block-processor crateStorageRpcCtxexplaining the two-tier architecture, query routing, cold lag, and deferred hash-based verification; ordering-guarantee rustdoc onBlockTagsexplaining atomic ordering, update/rewind safety, and race windowsCloses ENG-1901.
Test plan
cargo t -p signet-rpc— all 55 tests passcargo clippy -p signet-rpc --all-features --all-targets— cleancargo doc -p signet-rpc --no-deps— docs render cleanlycargo +nightly fmt— formatted🤖 Generated with Claude Code