feat: quincey #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2025
Merged
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces the new "quincey" feature with improved validation and resource registration changes. Key changes include:
- Updating resource registration identifiers in pkg/signet_node and pkg/builder.
- Adding a new Quincey package with component definitions, environment validations, and extensive tests.
- Implementing the Quincey component deployment logic with associated Kubernetes resources (deployment, service, virtual service, and authorization policies).
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/signet_node/signet_node.go | Updated the component resource registration string. |
| pkg/quincey/validation.go | Introduced environment validation functions for Quincey. |
| pkg/quincey/types.go | Added type definitions and constants for Quincey. |
| pkg/quincey/quincey_test.go | Added comprehensive unit tests for the Quincey component. |
| pkg/quincey/quincey.go | Implemented the core deployment logic for the Quincey component. |
| pkg/quincey/helpers.go | Added package declaration (helper file). |
| pkg/builder/builder.go | Updated the builder’s resource registration string. |
rswanson
force-pushed
the
swanny/consistent-labeling
branch
from
57f5e7d to
70c5d1d
Compare
rswanson
force-pushed
the
swanny/consistent-labeling
branch
from
70c5d1d to
d4b0242
Compare
rswanson
force-pushed
the
swanny/consistent-labeling
branch
from
d4b0242 to
5b2886c
Compare
This was referenced May 27, 2025
Merged
rswanson
force-pushed
the
swanny/consistent-labeling
branch
2 times, most recently
from
cfa82fa to
a76a2c1
Compare
rswanson
force-pushed
the
swanny/consistent-labeling
branch
from
a76a2c1 to
9c043f0
Compare
rswanson
force-pushed
the
swanny/quincey
branch
2 times, most recently
from
06b6d5a to
e5b79ed
Compare
rswanson
force-pushed
the
swanny/consistent-labeling
branch
3 times, most recently
from
4c6b6ea to
7d779ad
Compare
rswanson
changed the base branch from
swanny/consistent-labeling
to
graphite-base/8
Evalir
approved these changes
Jun 3, 2025
|
|
||
| // createConfigMap creates the ConfigMap for the Quincey service | ||
| func createConfigMap(ctx *pulumi.Context, args *QuinceyComponentArgs, parent *QuinceyComponent) (*corev1.ConfigMap, error) { | ||
| labels := utils.CreateResourceLabels(ComponentName, ServiceName, "signet", nil) |
There was a problem hiding this comment.
this "signet" string seems to be used as a constant for the labels. Maybe it could actually live as a constant somewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: quincey
fix: consistent naming
fix: use validate first