feat: split signet into signet-exex and signet-sidecar binaries#66
Merged
Conversation
prestwich
force-pushed
the
prestwich/dual-binary
branch
from
27361cf to
8f50ecf
Compare
prestwich
force-pushed
the
prestwich/dual-binary
branch
from
8f50ecf to
ee02393
Compare
Convert repo to a Cargo workspace with two member crates: - signet-exex: reth ExEx binary using SignetNodeBuilder API - signet-sidecar: standalone RPC follower with zero reth deps Split Dockerfile and update docker workflows for dual binaries. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
prestwich
force-pushed
the
prestwich/dual-binary
branch
from
ee02393 to
2837053
Compare
Fraser999
reviewed
Mar 24, 2026
|
|
||
| /// State the Signet node, using the provided config. | ||
| /// Start the Signet ExEx node with the provided config. | ||
| pub fn node(config: SignetNodeConfig) -> eyre::Result<()> { |
Contributor
There was a problem hiding this comment.
Suggested change
| pub fn node(config: SignetNodeConfig) -> eyre::Result<()> { | |
| pub(crate) fn node(config: SignetNodeConfig) -> eyre::Result<()> { |
Member
Author
There was a problem hiding this comment.
[Claude Code]
Done — node() is now pub(crate).
| let serve_config = ServeConfigEnv::from_env()?.try_into()?; | ||
| let rpc_config = StorageRpcConfigEnv::from_env()?.into(); | ||
|
|
||
| let cancel = CancellationToken::new(); |
Contributor
There was a problem hiding this comment.
Should this be hooked up to a signal-handler?
Same question for the similar one in the exex binary.
Member
Author
There was a problem hiding this comment.
[Claude Code]
Good call — added a spawn_shutdown_handler() in both binaries that listens for SIGINT (all platforms) and SIGTERM (unix), then cancels the token. This gives storage and other subsystems a window for graceful shutdown when the orchestrator sends SIGTERM.
Comment on lines
+8
to
+9
| homepage = "https://github.com/init4tech/signet-node" | ||
| repository = "https://github.com/init4tech/signet-node" |
Contributor
There was a problem hiding this comment.
Suggested change
| homepage = "https://github.com/init4tech/signet-node" | |
| repository = "https://github.com/init4tech/signet-node" | |
| homepage = "https://github.com/init4tech/signet" | |
| repository = "https://github.com/init4tech/signet" |
Member
Author
There was a problem hiding this comment.
[Claude Code]
Fixed — URLs now point to init4tech/signet.
Comment on lines
+8
to
+9
| homepage = "https://github.com/init4tech/signet-node" | ||
| repository = "https://github.com/init4tech/signet-node" |
Contributor
There was a problem hiding this comment.
Suggested change
| homepage = "https://github.com/init4tech/signet-node" | |
| repository = "https://github.com/init4tech/signet-node" | |
| homepage = "https://github.com/init4tech/signet" | |
| repository = "https://github.com/init4tech/signet" |
Member
Author
There was a problem hiding this comment.
[Claude Code]
Fixed — same URL correction applied here.
- Make `node()` pub(crate) in signet-exex - Remove unused tracing dependency from signet-sidecar - Fix homepage/repository URLs in both Cargo.toml files - Add signal-based shutdown handler (SIGINT + SIGTERM on unix, Ctrl+C on Windows) wired to the CancellationToken in both binaries Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fraser999
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signet-exex: reth ExEx binary (rename of existingsignetcrate), rewritten to use the newSignetNodeBuilderAPI withdecompose_exex_context()from node-componentssignet-sidecar: standalone RPC follower binary with zero reth dependencies, usinginit4-bin-basefor runtime setup and all config from environment variablesDockerfile.exexandDockerfile.sidecar, update ECR and GHCR workflowsDependencies
developbranch of node-componentsTest plan
cargo clippy -p signet-sidecar --all-targetspassescargo clippy -p signet-exex --all-targetspassescargo +nightly fmt --checkpassescargo tree -p signet-sidecar | grep -i rethreturns nothing🤖 Generated with Claude Code