fix(cold): drain in-flight reads before executing writes#39
Merged
Conversation
The task runner's select loop executed writes immediately without waiting for spawned read tasks to complete, allowing reads and writes to race on the backend. Close and drain the TaskTracker before each write to ensure exclusive access, then reopen for subsequent reads. Closes ENG-1980 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fraser999
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
select!loop executed writes immediately without draining spawned read tasks, allowing concurrent read/write access to the backend. this can cause inconsistent results for certain multi-tx read operationsTaskTracker::close()+wait()+reopen()before each write to ensure exclusive backend access, giving RwLock-like semanticsCloses ENG-1980
Test plan
cargo clippy -p signet-cold --all-features --all-targetscargo clippy -p signet-cold --no-default-features --all-targetscargo +nightly fmtcargo t -p signet-cold🤖 Generated with Claude Code