ci(open-knowledge): announce stable releases to Slack on publish#402
Merged
Conversation
Adds a best-effort Slack announcement step to desktop-release.yml, gated on the stable channel (steps.channel.outputs.channel == 'latest') so beta cuts never post. Placed after the draft->published promote step and gated on success() so only a fully-published release is announced; skipped on the workflow_dispatch recovery flow to avoid re-announcing an older tag. Reads the webhook from the SLACK_WEBHOOK_URL secret on inkeep/open-knowledge; no-ops cleanly when the secret is absent and downgrades any Slack delivery error to a warning so a release is never failed by a notification hiccup. GitOrigin-RevId: 69f2def9328562c9a2e5a814151f8f47d9ccca91
A tag composed of one long unbroken string (`#xxxxxxxxxxxxxxxxx...`)
overflowed past every surface that renders tag pills:
- Inline editor tags rendered via the `.tag` CSS class (`display:
inline-block; white-space: nowrap; no max-width`) extended past the
ProseMirror content column's right edge.
- The Properties panel list-widget pill (inline Tailwind: `inline-flex
rounded-full ... gap-0.5 ...`) extended past the value cell into
adjacent layout — the user-visible "background overflows in weird
ways" framing.
- The TagDialog title (`Documents tagged #{tag}` with `font-mono` on the
tag span) extended past the dialog's right edge.
- The TagDialog row pill (also `.tag` class) had the same overflow.
Root cause is the same across all three: no max-width and no
overflow-wrap on the pill, plus (for `.tag`) `white-space: nowrap`. A
normal-length tag is one word with no break opportunities, so when the
parent container is narrower than the pill the text refuses to wrap
and the pill blows past the boundary.
Fix:
- `.tag` (`globals.css`): drop `white-space: nowrap`, add `max-width:
100%` and `overflow-wrap: anywhere`. Normal-length tags retain the
single-line pill shape (no natural break opportunity → no wrap);
pathologically long ones break mid-string only when the container
would otherwise overflow.
- `PropertyWidgets.tsx` list-widget pill: add `max-w-full min-w-0
break-all` to the chip wrapper. Outer container already has
`flex-wrap`, so wrapped pills stack down; the constraint applies
per-pill to handle one super-long entry among shorter siblings.
- `TagDialog.tsx` title: add `break-all` to the `font-mono` span so the
title wraps within the dialog instead of overflowing the dialog's
intrinsic width.
Browser-verified end-to-end: long tag (`#dwdwdwdw...x10` repeats) in
both YAML `tags:` and inline `#tag` body — Properties pill wraps inside
its 239 px column (78 px tall), inline body tag wraps inside the
ProseMirror column, TagDialog title wraps to 3 lines within its 384 px
dialog. Normal-length tags (`#normal-short-tag`) look unchanged.
GitOrigin-RevId: ca9419d112722b894efdd6a7ff2d1302e1150e71
![inkeep-internal-ci[bot]](https://avatars.githubusercontent.com/in/2806322?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/28478646869). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.