feat(open-knowledge): open feedback from Cmd+K and the Help menu (#2858)#777
Merged
Conversation
* feat(open-knowledge): open feedback from Cmd+K and the Help menu The feedback form was only reachable from the Resources menu. It now has a command in the Cmd+K palette and a Help menu entry, declared once in the shared command registry so both surfaces render from one source. The command is host-agnostic, unlike Report a bug: the form posts to the hosted intake route, so the palette row shows up in the browser too. The Help entry fires to whichever window is focused, so the Project Navigator subscribes alongside the editor window. Also adds the row to AppMenubar, the in-app Help menu used on Windows and Linux where there is no native menu bar. That surface was missed when the native menu was wired. Two copy changes: Provide feedback becomes Send feedback. Provide was the only use of that verb in the whole catalog, and the form's own submit button says Send. Share was ruled out because it already means "give someone access" here (Share doc, Share folder, Share URL). Internal ids follow the label. Report a Bug becomes Report a bug in the native menu. The title case came from a per-placement menuLabelText override that bypassed the shared sentence-case label; dropping the override leaves one source for both surfaces. Both Help entries keep the ellipsis. Neither one acts on click, they open a form that needs input first, which is what the ellipsis signals. * test(open-knowledge): cover the AppMenubar Help entries AppMenubar is the Windows/Linux menu bar and returns null on darwin, so its Help rows never render during macOS review and had no coverage. Pins the dispatch payload for Send feedback and Report a bug, the darwin null gate, and the entry labels so the two Help surfaces cannot drift apart. * docs(open-knowledge): match the renamed Report a bug menu label The rename left six living-doc references to the old title-case label. Covers the desktop README plus the public docs site, where the label names the entry point for the bug-report flow and the intake env var. Historical records keep the old casing on purpose: the CLI changelog documents what shipped at that version, and the research evidence files quote external article titles. * test(open-knowledge): cover the Navigator and native-menu feedback paths Two gaps review caught. The Navigator subscribes to send-feedback and owns the dialog whenever it is the focused window, but its menu-action suite covered only the sibling actions. And the native menu's send-feedback binding had no click test, so a copy-paste to onReportBug would still pass the parity ratchet, which only asserts a binding exists. Both are mutation-checked: dropping the Navigator branch and repointing the menu binding each turn exactly one of the new tests red. GitOrigin-RevId: 3e3100438b6b072a0bd0cd83c3ecf0e54458b84f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara-translated 1 Inkeep OSS change. Rebase-merge this PR so the prepared commit lands directly on public main.