Skip to content

Conversation

@markopolo123
Copy link

Proposed blog post for inlets.

Signed-off-by: Mark Sharpley

Signed-off-by: Mark Sharpley <msh@Marks-MacBook-Pro.local>
@alexellis
Copy link
Member

Hi @markopolo123, I sent you some feedback via email. Let me know when you've had time to push that?

Regards,

Alex

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review sent to author

@alexellis
Copy link
Member

@markopolo123 it's been a couple of weeks since I left feedback, can you tell me when I should expect the changes so that I can review them again and potentially get your story published?

@derek derek bot added the no-dco label Jun 13, 2021
@derek
Copy link

derek bot commented Jun 13, 2021

Thank you for your contribution. It seems that one or more of your commits have an anonymous email address. Please consider signing your commits with a valid email address. Please see our contributing guide.

@markopolo123
Copy link
Author

@markopolo123 it's been a couple of weeks since I left feedback, can you tell me when I should expect the changes so that I can review them again and potentially get your story published?

Pushed changes, let me know if you require further changes.
Best,
Mark

@alexellis
Copy link
Member

Could you squash all your commits into one?

https://www.youtube.com/watch?v=8j0H6urZ-bU

@alexellis
Copy link
Member

Just checked out the latest update, do you have an image of the Raspberry Pi, or the battery + kit?

@markopolo123
Copy link
Author

Just checked out the latest update, do you have an image of the Raspberry Pi, or the battery + kit?

Yeah, I can add some more pictures.

@alexellis
Copy link
Member

I'm going to push a version of the blog post, then can you send a PR to add the pictures in JPG format? I think it would really add to the story :)

@alexellis alexellis closed this Jul 13, 2021
@alexellis
Copy link
Member

Your post will be live at: https://inlets.dev/blog/2021/07/13/inlets-narrowboat.html

So, you can send a PR to master in a new/fresh branch and enrich the post. The date has also changed to blog/_posts/2021-07-13-inlets-narrowboat.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants