Minimax h3 lora training - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MiniMax H3 LoRA training
Adds MiniMax H3 as a fourth trainable architecture. Trains on still images, and the adapter applies to video.
What's new
loraport on all four H3 nodes in runner.py, so the trained file is usableMeasured on an L40S
Fixes two live bugs in the existing trainer
_to_devicecast every non-masktensor to the compute dtype, which would destroy index tensorsis_loaded_in_4bit, so NF4 runs silently used the generic LoRA layer instead of the bitsandbytes one. Affects Krea 2 and FLUX.2 todayVerified
Known, not fixed here
UP042lint errors in unrelated files, deferred deliberatelyAlso bumps to 1.2.62.
Closes #
Checklist
npm run typecheck && npm run lint && npm run testpasscd core && ruff check . && uv run pytest -qpass (if the engine changed)git commit -s)