Support for setting custom GcmListener - #21
Merged
Conversation
We would like to integrate your library in our library and we don’t have access to the Application instance. That’s why we can’t implement GcmListener directly. This commit adds method setGcmListener() which should be (optionally) called in Application.onCreate()
Contributor
Author
|
cc @TOMIK-DEV |
|
Thanks! This dedinitely makes sense and could be used in such cases. I don't see any issues so I am merging this. |
DanielNovak
pushed a commit
that referenced
this pull request
Mar 4, 2015
Support for setting custom GcmListener
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to integrate your library in our library and we don’t
have access to the Application instance. That’s why we can’t implement
GcmListener directly. This commit adds method setGcmListener() which
should be (optionally) called in Application.onCreate()