Refactor: Combine byte array macros with hash.rs #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowhung
requested review from
SupernaviX,
alexwoods,
golddydev,
sandtreader and
whankinsiv
lowhung
changed the title
byte_array module and update references across modules.
lowhung
commented
Oct 29, 2025
lowhung
force-pushed
the
lowhung/introduce-combined-hash-file
branch
from
b33c4c6 to
8fd44b2
Compare
…and Bech32 encoding support. Remove redundant `byte_array` module and update references across modules.
lowhung
force-pushed
the
lowhung/introduce-combined-hash-file
branch
from
8fd44b2 to
8952522
Compare
…d unused examples
lowhung
commented
Oct 29, 2025
whankinsiv
reviewed
Oct 29, 2025
…handling, adjust Bech32 encoding/decoding with detailed context
…handling, adjust Bech32 encoding/decoding with detailed context
lowhung
force-pushed
the
lowhung/introduce-combined-hash-file
branch
from
cee52c4 to
84cd45a
Compare
whankinsiv
approved these changes
Oct 29, 2025
lowhung
commented
Oct 29, 2025
| /// Pool ID (28-byte hash) | ||
| pub type PoolId = Hash<28>; | ||
|
|
||
| pub type AddrKeyhash = Hash<28>; |
Collaborator
Author
There was a problem hiding this comment.
Keeping these local for now, but in my follow-up PR I'll move these into types.rs
SupernaviX
reviewed
Oct 30, 2025
| } | ||
|
|
||
| #[test] | ||
| #[ignore] |
SupernaviX
approved these changes
Oct 30, 2025
sandtreader
approved these changes
Oct 30, 2025
Collaborator
sandtreader
left a comment
sandtreader
left a comment
There was a problem hiding this comment.
Looks great, best of both worlds :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Implements #257
This PR combines the byte array macros @alexwoods wrote with the hash declarations so we get both options in one file so it's easier to find.