Undelegate stake from retiring pools #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix divergence in active stake calculations Also added special cut-down config to only run core functions, for reward and performance testing $ cargo run --release -- --config omnibus-rewards.toml
golddydev
approved these changes
Dec 2, 2025
lowhung
approved these changes
Dec 2, 2025
shd
approved these changes
Dec 3, 2025
Collaborator
shd
left a comment
shd
left a comment
There was a problem hiding this comment.
SPDD broadast at epochs 209,210,211 are equal to Haskell node data.
Collaborator
Author
@shd Great! I take it that was not the case before? Does it then break at 212? We think the rewards paid are correct up to 215. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix divergence in active stake calculations
Also added special cut-down config to only run core functions, for reward and performance testing
$ cargo run --release -- --config omnibus-rewards.toml
Description
Ensure that when a pool retires, all stake addresses that delegate to it are marked as undelegated. This will affect
the 'active_stake' totals
Related Issue(s)
Related to, but does not fix, #8
How was this tested?
Additional unit test, needs verification against active stake output from Haskell (@shd has the figures)
Checklist
Impact / Side effects
Reviewer notes / Areas to focus
Fixes #441