feat: add header and nonces modules for snapshot bootstrapper #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowhung
changed the title
whankinsiv
approved these changes
Dec 2, 2025
| pub struct HeaderContext { | ||
| pub point: Point, | ||
| pub block_number: u64, | ||
| pub block_hash: Hash<32>, |
Collaborator
There was a problem hiding this comment.
The point already contains the block hash so this field shouldn't be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for reading nonces and block header cbor into the snapshot bootstrapper, prior to doing snapshot downloading -> parsing.
Related Issue(s)
Relates to #381
How was this tested?
--
cargo test --package acropolis_module_snapshot_bootstrapper--
cargo test --package acropolis_module_snapshot_bootstrapper --lib header--
cargo test --package acropolis_module_snapshot_bootstrapper --lib noncesmake runChecklist
Impact / Side effects
Should be no side effects as a result of this PR. This is an additive change.
Reviewer notes / Areas to focus