Publish rollback messages #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupernaviX
requested review from
lowhung,
shd and
whankinsiv
and removed request for
shd and
whankinsiv
lowhung
approved these changes
Dec 3, 2025
| ChainEvent::RollForward { header, body } => { | ||
| self.block_sink.announce_roll_forward(header, body).await?; | ||
| self.published_blocks += 1; | ||
| if self.published_blocks.is_multiple_of(100) { |
Collaborator
There was a problem hiding this comment.
This might be a silly question, but why do we log that a specific block was published every 100 blocks?
Collaborator
Author
There was a problem hiding this comment.
Two reasons:
UpstreamChainFetcherhad the same line- it's been useful for me, for observing signs of life
| }; | ||
| let hash = Hash::try_from(hash).unwrap_or_default(); | ||
| if let Some(slot_blocks) = self.blocks.get(&slot) | ||
| && let Some(header) = slot_blocks.header(hash) |
Collaborator
There was a problem hiding this comment.
I didn't know you could let chain like this!
Collaborator
Author
There was a problem hiding this comment.
It's a feature that's less than a year old, my favorite from Rust 2024 edition
| } | ||
|
|
||
| #[test] | ||
| fn should_gracefully_switch_to_new_chain_at_older_head() { |
whankinsiv
approved these changes
Dec 3, 2025
Collaborator
whankinsiv
left a comment
whankinsiv
left a comment
There was a problem hiding this comment.
Looks great! Really nice tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the PeerNetworkInterface module to produce rollback messages whenever it rolls back. We need this for custom indexers, which should be able to handle rollbacks immediately without waiting for a roll forward.
The logic changes were relatively involved:
This also fixes some other chain-sync bugs:
Related Issue(s)
Completes #421
How was this tested?
Almost entirely through unit tests, though with some manual tests.
Checklist
Impact / Side effects
The node can actually emit rollback messages now, meaning they propagate downstream.
Reviewer notes / Areas to focus
The most involved method is
switch_head_to_peer, which gets called whenever we change which peer we're following. It has to gracefully handle rolling our chain back to that peer's head, and if we don't know where that peer's head is yet it sets a flag to call it again when we know more.