Report tip status in BlockInfo #454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
tip_slotfield toBlockInfo, indicating which slot "the tip" is currently at. This field isNoneby default and while e.g. syncing from mithril, but we populate it while transmitting blocks from the ChainSync mini-protocol. This field currently refers to the tip of the chain of whichever peer we've decided to follow.Also adds a test for a regression from an older implementation of PeerNetworkInterface.
Related Issue(s)
Completes #422
How was this tested?
I synced the node with preview after booting from a mithril snapshot, confirming that
Checklist
Impact / Side effects
An extra optional u64 in BlockInfo which gets passed everywhere
Reviewer notes / Areas to focus
The only non-mechanical changes are updates to BlockInfo and PeerNetworkInterface