Ajw/389 bootstrap spo module #458
Merged
+298
−856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 3, 2025 21:14
- Read straight to common crate types in streaming snapshot - Remove minicbor encoding/decoding from core common types for now - Remove decoding code for ledger state module
added 2 commits
December 10, 2025 13:54
sandtreader
approved these changes
Dec 10, 2025
Collaborator
sandtreader
left a comment
sandtreader
left a comment
There was a problem hiding this comment.
Looks like a great general pattern - nice that we can decode things like IP addresses directly, and that SPOState's state is literally just the bootstrap message content.
Closed
4 tasks
lowhung
approved these changes
Dec 10, 2025
Collaborator
lowhung
left a comment
lowhung
left a comment
There was a problem hiding this comment.
So clean! Nice to see so much code removal too.
| ); | ||
|
|
||
| // pool_registration (third element) | ||
| let pools: VMap<PoolId, PoolParams> = decoder |
Collaborator
There was a problem hiding this comment.
Nice to see all this ugly code go away.
| let start = Instant::now(); | ||
|
|
||
| match parser.parse(&mut callbacks) { | ||
| match parser.parse(&mut callbacks, NetworkId::Mainnet) { |
Collaborator
There was a problem hiding this comment.
Pulling the networkid out is nice.
buddhisthead
approved these changes
Dec 10, 2025
Collaborator
buddhisthead
left a comment
buddhisthead
left a comment
There was a problem hiding this comment.
Really nice work, Alex. Thanks for cleaning up all of my gross decoding! This looks great. I ran the test and verified it still works :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the streaming snapshot reader to pass acropolis common types to the pools callback and reworks the old snapshot handling code to work with the new bootstrap publisher.
Related Issue(s)
Implements #389.
How was this tested?
From real snapshots and examining the /pools/ endpoint.
Checklist
Impact / Side effects
Reviewer notes / Areas to focus
The rework to the streaming reader would be good to receive feedback on since it's the main part of this PR and may be used as a future pattern for other bootstrap modules